Hi,
so I did some work on this and it seems to be finally working (I had to fix
a couple of bugs in the run, to take care of both direct and "classic"
rendering path).
As prospected the change is partly in GeoTools, in particular in
StreamingRenderer to add support for the "by layer" interpolation hint.
For the GeoServer work, unfortunately I didn't managed to reuse the WCS
interpolation kvp parser, for a couple of reasons:
- we want to support comma delimited values to allow for multiple layers
having different interpolation (the WCS parser supports only one value)
- the wcs parser is tied to EMF classes for WCS
I would like to start preparing pull requests for this part, but I am not
sure how to proceed due to "missing JIRA". I would like to refer the JIRA
number from the PR, as usual.
Is it possible to coordinate for "booking" JIRA numbers that I will create
as soon as possible on the new JIRA?
It seems the first availables are GEOT-5064 and GEOS-6965. Can I use them
for this work?
Thanks
Mauro
2015-03-27 15:51 GMT+01:00 Mauro Bartolomeoli <
[email protected]>:
> Hi,
>
> 2015-03-27 14:12 GMT+01:00 Andrea Aime <[email protected]>:
>
>> On Fri, Mar 27, 2015 at 9:15 AM, Mauro Bartolomeoli <
>> [email protected]> wrote:
>>
>>> Hi Jody,
>>>
>>> 2015-03-26 20:22 GMT+01:00 Jody Garnett <[email protected]>:
>>>
>>>> Wouldn't it be more appropriate to do this on a layer by layer basis?
>>>> Or are you focused on the final map production ...
>>>>
>>>>
>>> If you mean that the interpolation parameter should be a comma delimited
>>> list with one value for each layer (similar to style), this would make the
>>> change a bit more complex, because currently interpolation is achieved
>>> through rendering hints that are passed to StreamingRenderer for the whole
>>> rendering. If we want to make it layers specific we would need to move the
>>> logic inside StreamingRenderer, while now it's in
>>> RenderedImageMapOutputFormat. It's not impossible, I could investigate on
>>> the effort if people prefer to make it work this way.
>>>
>>
>> Indeed, that is why we have only the setting at the entire server level,
>> because the streaming renderer cannot do interpolation per layer... not a
>> massive change, but not entirely trivial I warn you, you'll have to modify
>> both streaming renderer and grid coverage renderer, as well as, I suppose,
>> RasterLayer/GridCoverageLayer/GridReaderLayer to hold the interpolation
>> value (don't the the interpolation setting does anything for vector
>> layers... might be wrong though).
>>
>
> I had a quick look, and for sure StreamingRenderer needs to be touched.
>
> There is a generic getRenderingInterpolation() method that
> RenderCoverageReaderRequest call to get the current hint. We should
> probably make the interpolation value a property of the reader, so that we
> can set it when we create the reader, removing delegation to the outer
> class method.
> GridCoverageRenderer already accepts an Interpolation object, so probably
> we just need to set it appropriately in RenderCoverageReaderRequest.
>
> I also think that the hint only affects raster layers. From this first
> investigation it doesn't seem too difficult, so probably is a good idea to
> make the parameter "multivalued".
>
>
Regards,
Mauro
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.
==
Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
