Follow up to today's meeting and review of https://github.com/geotools/geotools/pull/1067
Dave was kind enough to talk me through it, reviewed code, fixed up formatting etc... and it looks good to go. There is one part I want to focus on (just to make sure geotools-devel is aware of the change) - the logic around the following <https://github.com/DBlasby/geotools/blob/better_clip/modules/library/render/src/main/java/org/geotools/renderer/lite/StreamingRenderer.java#L2558> : Geometry g = clipper.clipSafe(shape.getGeometry(), preserveTopology, 1); The flag preserveTopology is used for perpendicular offset styling of polygon data. Previously this logic would ask clipSafe to do a slower JTS implementation of clip - and only use the quick GeoTools implementation of clip for the perpendicular offset styling of polygon data above. I expect that is a bug... After pull request #1067 we use the quick GeoTools implementation most of the time, and only use the "ensureValid" JTS Clip routine for the perpendicular offset styling of polygon data. So this should be faster, but want to provide appropriate warning. -- Jody Garnett
------------------------------------------------------------------------------
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
