mattrpav commented on code in PR #1288:
URL: https://github.com/apache/activemq/pull/1288#discussion_r1813027560
##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/BrokerView.java:
##########
@@ -280,11 +280,21 @@ public ObjectName[] getTopics() {
return safeGetBroker().getTopicsNonSuppressed();
}
+ @Override
+ public int getTotalTopicsCount() {
+ return getTopics().length;
+ }
+
@Override
public ObjectName[] getQueues() {
return safeGetBroker().getQueuesNonSuppressed();
}
+ @Override
+ public int getTotalQueuesCount() {
+ return getQueues().length;
Review Comment:
Right! That is exactly my point. The getQueues pulls in what is _registered_
in JMX, not what is present in the broker. JMX suppression is to prevent
overhead caused by registering objects into JMX -- specifically for
environments with _lots_ of queues and queues that are one-time-use queues.
If a user enable suppression for performance reasons, they still need base
metrics. The BrokerView metrics should be consistent and provide -- what is the
in broker?
I think the confusion is around what does the getQueues() method mean?
getQueues() _not_ "What queues are in the broker?" -- getQueues() is "what
queues are _registered in JMX_?"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
