pa-deasy opened a new pull request, #1354:
URL: https://github.com/apache/activemq/pull/1354

   By default non persistent messages are set to persistent when being sent to 
a dead letter queue. This improvement adds `preserveDeliveryMode` to 
deadLetterStrategy which allows the original non-persistent delivery mode to be 
preserved.
   
   This is a WIP progress, I'm looking for early feedback from the community to 
ensure my changes are reasonable.
   I've opted to move dead letter queue message preparation logic to the 
`AbstractDeadLetterStrategy` class. I believe this makes sense as the strategy 
influences how the message is prepared. It also reduces responsibility in the 
`RegionBroker` which is already quite large.
   
   I will add tests if I get feedback that the approach is reasonable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For additional commands, e-mail: gitbox-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact


Reply via email to