shunping commented on code in PR #37021:
URL: https://github.com/apache/beam/pull/37021#discussion_r2594481185
##########
sdks/go/pkg/beam/runners/prism/internal/jobservices/server.go:
##########
@@ -80,6 +81,10 @@ func NewServer(port int, execute func(*Job)) *Server {
s.logger.Info("Serving JobManagement", slog.String("endpoint",
s.Endpoint()))
opts := []grpc.ServerOption{
grpc.MaxRecvMsgSize(math.MaxInt32),
+ grpc.KeepaliveEnforcementPolicy(keepalive.EnforcementPolicy{
+ MinTime: 20 * time.Second, // Minimum
duration a client should wait before sending a keepalive ping
Review Comment:
The 20-second min time matches the option set in the python client:
https://github.com/liferoad/beam/blob/782a0e7cc26e582c31534253fa5a00018bce4c38/sdks/python/apache_beam/runners/worker/channel_factory.py#L27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
