Comment here as well:
On Thu, May 02, 2019 at 08:55:36AM +0200, Alexander Graf wrote:
> We hit an error case which only got triggered on ARM Thumb code. So
> let's make sure we test that combination as well.
This is the default for at least several and possibly most ARMv7-A
distributions/prebuilt toolchains.
So while a good idea, if you want to specifically force instruction
set use, the opposite case needs to be set up with -marm.
> Signed-off-by: Alexander Graf <ag...@csgraf.de>
> ---
> .travis.yml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/.travis.yml b/.travis.yml
> index 8571d9f1c..d8f6170e6 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -106,6 +106,11 @@ matrix:
> env:
> - GRUB_TARGETS="arm-coreboot-vexpress arm-efi arm-uboot"
> - CROSS_TARGETS="arm-linux-gnueabi"
But, wait...
arm-linux-gnueabi is the softfloat (v5te) toolchain - if we want to
test that, fine - but we definitely need to test arm-linux-gnueabihf.
First of all, I would expect that this toolchain will not use T32
(Thumb-2) instructions by default, so much of the code will end up
being compiled as A32 anyway.
/
Leif
> + - name: "arm_thumb"
> + env:
> + - GRUB_TARGETS="arm-coreboot-vexpress arm-efi arm-uboot"
> + - CROSS_TARGETS="arm-linux-gnueabi"
> + - TARGET_CFLAGS="-mthumb"
> - name: "arm64"
> env:
> - GRUB_TARGETS="arm64-efi"
> --
> 2.16.4
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
