On Tue, May 14, 2019 at 06:17:58AM -0700, Alexander Graf wrote:
> On 10.05.19 13:03, Daniel Kiper wrote:
> > On Thu, May 02, 2019 at 08:55:30AM +0200, Alexander Graf wrote:
> >> Commit 35b909062e7b3 ("gnulib: Upgrade Gnulib and switch to bootstrap
> >> tool")
> >> changed the build flow from running ./autogen.sh to running ./bootstrap
> >> but missed to update .travis.yml. Adapt it accordingly.
> >>
> >> Fixes: 35b909062e7b3 ("gnulib: Upgrade Gnulib and switch to bootstrap
> >> tool")
> >> Signed-off-by: Alexander Graf <ag...@csgraf.de>
> >>
> >> ---
> >>
> >> v1 -> v2:
> >>
> >> - use local gnulib copy (saves ~3m git checkout time)
> >> ---
> >> .travis.yml | 7 ++++++-
> >> 1 file changed, 6 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/.travis.yml b/.travis.yml
> >> index 81de20fa3..6b8f97830 100644
> >> --- a/.travis.yml
> >> +++ b/.travis.yml
> >> @@ -18,6 +18,7 @@ addons:
> >> - python
> >> - qemu-system
> >> - unifont
> >> + - gnulib
> >>
> >> env:
> >> global:
> >> @@ -35,7 +36,11 @@ before_script:
> >> script:
> >> # Comments must be outside the command strings below, or the Travis
> >> parser
> >> # will get confused.
> >> - - ./autogen.sh
> >> +
> >> + # The Ubuntu gnulib does not compile with gcc8, so only use it with the
> >> system compiler
> >> + - if [ ! "$CROSS_TARGETS" ]; then rm -rf gnulib; ln -s
> >> /usr/share/gnulib; fi
> > I would not depend on it at all. Could you drop this and gnulib package
> > addition above?
>
>
> The gnulib package dependency gets us all the other dependencies that
> gnulib pulls in - and is much more obvious than listing them explicitly.
>
> The hack here shaves down compilation time by a few minutes for x86
> targets - and latency is definitely important. I'd really prefer to
> leave it in.
OK but please add somewhere a comment similar to above.
Daniel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
