Minor thing, and I'm not sure if we have a convention for this, but
it'd
be neat to keep the use-module statements ordered alphabetically.
Ordered alphabetically!
Again, I'm under the impression that this should rather be gpl2+. I'd
be
happy to be proven wrong otherwise!
+ (properties '((upstream-name . "FileZilla")))))
Otherwise LGTM (haven't tested though).
Updated patch. Thanks
From c46abaa7314aac73ad8e7a368e86d91fa126b4d3 Mon Sep 17 00:00:00 2001
From: rennes <ren...@openmailbox.org>
Date: Tue, 14 Feb 2017 23:27:11 -0600
Subject: [PATCH 3/3] gnu: Add filezilla.
* gnu/packages/ftp.scm (filezilla): New variable.
---
gnu/packages/ftp.scm | 50 ++++++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 48 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/ftp.scm b/gnu/packages/ftp.scm
index 60693aac6..ddbf5a08d 100644
--- a/gnu/packages/ftp.scm
+++ b/gnu/packages/ftp.scm
@@ -28,12 +28,20 @@
#:use-module (gnu packages)
#:use-module (gnu packages autotools)
#:use-module (gnu packages check)
+ #:use-module (gnu packages compression)
+ #:use-module (gnu packages databases)
+ #:use-module (gnu packages freedesktop)
#:use-module (gnu packages gettext)
+ #:use-module (gnu packages glib)
+ #:use-module (gnu packages gtk)
+ #:use-module (gnu packages libidn)
#:use-module (gnu packages ncurses)
- #:use-module (gnu packages readline)
+ #:use-module (gnu packages nettle)
#:use-module (gnu packages pkg-config)
+ #:use-module (gnu packages readline)
#:use-module (gnu packages tls)
- #:use-module (gnu packages compression))
+ #:use-module (gnu packages wxwidgets)
+ #:use-module (gnu packages xml))
(define-public lftp
(package
@@ -183,3 +191,41 @@ as required.")
"This package provides some basic functionality to build high-performing,
platform-independent programs.")
(license gpl2+)))
+
+(define-public filezilla
+ (package
+ (name "filezilla")
+ (version "3.24.0")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://sourceforge.net/projects/" name
+ "/files/FileZilla_Client/" version
+ "/FileZilla_" version "_src" ".tar.bz2"))
+ (sha256
+ (base32
+ "1bacrl8lj90hqbh129hpbgqj78k1i84j83rkzn507jnykj4x8p9x"))))
+ (build-system gnu-build-system)
+ (native-inputs
+ `(("gettext" ,gettext-minimal)
+ ("pkg-config" ,pkg-config)
+ ("pugixml" ,pugixml)
+ ("xdg-utils" ,xdg-utils)))
+ (inputs
+ `(("dbus" ,dbus)
+ ("gnutls" ,gnutls)
+ ("gtk+" ,gtk+)
+ ("libfilezilla" ,libfilezilla)
+ ("libidn" ,libidn)
+ ("nettle" ,nettle)
+ ("sqlite" ,sqlite)
+ ("wxwidgets" ,wxwidgets)))
+ (home-page "https://filezilla-project.org")
+ (synopsis "Full-featured graphical FTP/FTPS/SFTP client")
+ (description
+ "Filezilla client supports FTP, FTP over SSL/TLS (FTPS),
+SSH File Transfer Protocol (SFTP), HTTP/1.1, SOCKS5, FTP-Proxy, IPv6
+and others features such as bookmarks, drag and drop, filename filters,
+directory comparison and more.")
+ (license gpl2+)
+ (properties '((upstream-name . "FileZilla")))))
--
2.11.0