[
https://issues.apache.org/jira/browse/HADOOP-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531984
]
Hadoop QA commented on HADOOP-1978:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12366970/editsNew-0-15.patch
against trunk revision r581427.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/871/testReport/
Findbugs warnings:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/871/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/871/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/871/console
This message is automatically generated.
> Name-node should remove edits.new during startup rather than renaming it to
> edits.
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-1978
> URL: https://issues.apache.org/jira/browse/HADOOP-1978
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.13.1
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Priority: Blocker
> Fix For: 0.14.2, 0.15.0
>
> Attachments: editsNew-0-14.patch, editsNew-0-15.patch
>
>
> Secondary name-node fails in the middle. The main name-node writes its
> journal transactions into edits.new at that time.
> If the name-node is shut down after that and restarted, then loadFSImage()
> reads current image file, merges it with the edits
> file and with the edits.new file.
> Now saveFSImage() saves new image file, creates empty edits file, and then
> calls rollFSImage(), which particularly renames
> edits.new into edits. This is a mistake, during startup edits.new should be
> merely removed after merging it with the image.
> The purpose of calling rollFSImage() during startups imho is to recover from
> an unsuccessful checkpoint. So an easy fix
> is to empty edits.new before calling rollFSImage the same as edits are
> emptied, then rollFSImage will rename empty file
> to empty which gives us the desired result.
> We should fix this bug both in 0.14 and 0.15. I make it a blocker for 0.15.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
