Paulex,
I have some thoughts about the patch. It looks good but the following two
things:
1) java/io/InputStreamReader.
getHistoricalName(String name) should not be public I think.
2) java/io/OutputStreamWriter.getEncoding().
You probably meant
if (!isOpen()) {
return null;
}
instead of
if (encoder == null) {
return null;
}
since this method returns null if the stream has been closed.
Thanks.
On 3/8/06, Paulex Yang (JIRA) <[EMAIL PROTECTED]> wrote:
>
> [ http://issues.apache.org/jira/browse/HARMONY-156?page=all ]
>
> Paulex Yang updated HARMONY-156:
> --------------------------------
>
> Attachment: patch_156.txt
> patch_156_test.txt
>
> As no one has better idea than my prior proposal, i.e., save the mapping
> between historical name and canonical name, I created the patch for this
> solution. The affected package is luni/java.io.
>
> --
> Dmitry M. Kononov
> Intel Managed Runtime Division
