[
https://issues.apache.org/jira/browse/HDFS-1061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860584#action_12860584
]
Jakob Homan commented on HDFS-1061:
-----------------------------------
The patch looks good, but Hudson is right - we should have some basic sanity
unit tests here, if for no other reason, than to catch any mistakes that may be
introduced later that don't jive with the assumptions made in the patch. The
new logic in INodeFile is easily testable. I'll +1 and commit once some basic
unit tests are included.
> Memory footprint optimization for INodeFile object.
> ----------------------------------------------------
>
> Key: HDFS-1061
> URL: https://issues.apache.org/jira/browse/HDFS-1061
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 0.22.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-1061.patch
>
>
> I am proposing a footprint optimization to merge blockReplication and
> preferredBlockSize fields into one 'long header' field in INodeFile class.
> This saves 8 bytes per INodeFile object on a 64 bit JVM. This memory
> optimization is transparent and changes are very minimal.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
