[
https://issues.apache.org/jira/browse/HDFS-1061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865875#action_12865875
]
Jakob Homan commented on HDFS-1061:
-----------------------------------
Thanks for the tests Bharath.
* For number of replicas does a checking for less than 0 make sense? Should it
be <= 0. A replica count of 0 seems odd...
* For the tests that are expected to throw an exception, it's not necessary to
include the always-fails assert. Junit will take care of this. (Also, Junit
provides the fail(msg) method, which is equivalent to assertTrue(false)).
Other than that looks good.
> Memory footprint optimization for INodeFile object.
> ----------------------------------------------------
>
> Key: HDFS-1061
> URL: https://issues.apache.org/jira/browse/HDFS-1061
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 0.22.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HDFS-1061-1.patch, HDFS-1061-2.patch, HDFS-1061.patch
>
>
> I am proposing a footprint optimization to merge blockReplication and
> preferredBlockSize fields into one 'long header' field in INodeFile class.
> This saves 8 bytes per INodeFile object on a 64 bit JVM. This memory
> optimization is transparent and changes are very minimal.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
