[
https://issues.apache.org/jira/browse/HDFS-7889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482890#comment-14482890
]
Li Bo commented on HDFS-7889:
-----------------------------
hi, Zhe
Thanks for your review and update of patch.
1. will fix it
2. Yes, we can come back to modify it after related subtasks are ready.
3. in {{encode()}}, just copy the references of buffer in order to call
raw coder’s encode function
4. Different streamers share the same {{ExtendedBlock}}, so I think we can
use any of them.
5. Yes, that's a good point. Will fix it.
6. Not very clear about your meaning. What hook? DFSStripedOutputStream is
created in previous sentence {{os = fs.create(TestPath);}}
7. Could we set the limit to 90 or 100 chars? 80 chars seem a little
short, and there’re many lines with more than 80 chars(<100) in current code.
8. Yes, will verify parity data content in the unit test. One problem is
if the last block group is smaller than a stripe, only 3 block locations will
be returned after calling {{fs.getClient().getLocationBlocks(src, 0L)}}. Could
you have a check about this problem?
> Subclass DFSOutputStream to support writing striping layout files
> -----------------------------------------------------------------
>
> Key: HDFS-7889
> URL: https://issues.apache.org/jira/browse/HDFS-7889
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Li Bo
> Assignee: Li Bo
> Attachments: HDFS-7889-001.patch, HDFS-7889-002.patch,
> HDFS-7889-003.patch, HDFS-7889-004.patch, HDFS-7889-005.patch,
> HDFS-7889-006.patch, HDFS-7889-007.patch, HDFS-7889-008.patch,
> HDFS-7889-009.patch
>
>
> After HDFS-7888, we can subclass {{DFSOutputStream}} to support writing
> striping layout files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
