[
https://issues.apache.org/jira/browse/HDFS-10933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554607#comment-15554607
]
Wei-Chiu Chuang commented on HDFS-10933:
----------------------------------------
Thanks a lot for working on this, [~tasanuma0829]. I took a quick look and I
think it's mostly good. A few nits:
* I think you can also initialize the conf object in an {{@Before}} method.
* A few methods calls {{shutdownCluster();}} at the end. This is not needed.
> Refactor TestFsck
> -----------------
>
> Key: HDFS-10933
> URL: https://issues.apache.org/jira/browse/HDFS-10933
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Takanobu Asanuma
> Assignee: Takanobu Asanuma
> Priority: Minor
> Attachments: HDFS-10933.1.patch, HDFS-10933.2.patch,
> HDFS-10933.WIP.1.patch
>
>
> {{TestFsck}} should be refactored.
> - use @Before @After annotations
> - improve loggings
> - fix checkstyle warnings
> etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
