[
https://issues.apache.org/jira/browse/HDFS-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034136#comment-13034136
]
Todd Lipcon commented on HDFS-1573:
-----------------------------------
Woops, not sure how that Cyrillic 'с' got in there instead of a Latin 'c' (they
look the same in most fonts).
bq. Why using com.google.common.annotations.VisibleForTesting?
Since we have Guava around now, why not? It's a nice annotation to say that the
function is only meant to be used by test code.
bq. hdfsTimeout and clientName are final constants. So these two methods are
not needed
Those are needed so that DFSClient can be mocked in the unit tests. It's not
possible to stub a field, so we need it to be accessed through an accessor. I
can mark these as @VisibleForTesting as well?
> LeaseChecker thread name trace not that useful
> ----------------------------------------------
>
> Key: HDFS-1573
> URL: https://issues.apache.org/jira/browse/HDFS-1573
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Trivial
> Labels: newbie
> Fix For: 0.23.0
>
> Attachments: hdfs-1573.txt
>
>
> The LeaseChecker thread in DFSClient will put a stack trace in its thread
> name, theoretically to help debug cases where these threads get leaked.
> However it just shows the stack trace of whoever is asking for the thread's
> name, not the stack trace of when the thread was allocated. I'd like to fix
> this so that you can see where the thread got started, which was presumably
> its original intent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
