[
https://issues.apache.org/jira/browse/HDFS-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034371#comment-13034371
]
Todd Lipcon commented on HDFS-1573:
-----------------------------------
bq. Is the annotation currently used in our test framework? There are various
annotation packages. Why choose Guava?
Guava was already included in Hadoop Common since HADOOP-6919. I opened a
thread on the mailing list a couple months ago and received several +1s to the
effect that it's a useful dependency. Keep in mind that Guava provides a lot of
useful stuff - @VisibleForTesting is just one little thing in there.
We don't currently do anything useful with the annotation, but it's at least as
good as a comment that says /** Visible for testing */ - but better since down
the road we could use it to exclude JavaDoc generation, for example. If you're
strongly against it, happy to remove.
> LeaseChecker thread name trace not that useful
> ----------------------------------------------
>
> Key: HDFS-1573
> URL: https://issues.apache.org/jira/browse/HDFS-1573
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Trivial
> Labels: newbie
> Fix For: 0.23.0
>
> Attachments: hdfs-1573.txt, hdfs-1573.txt
>
>
> The LeaseChecker thread in DFSClient will put a stack trace in its thread
> name, theoretically to help debug cases where these threads get leaked.
> However it just shows the stack trace of whoever is asking for the thread's
> name, not the stack trace of when the thread was allocated. I'd like to fix
> this so that you can see where the thread got started, which was presumably
> its original intent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
