[
https://issues.apache.org/jira/browse/HDFS-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040990#comment-13040990
]
Todd Lipcon commented on HDFS-1949:
-----------------------------------
- The following introduces invalid markup and is also too many columns wide:
{code}
- out.print("<form action=\"/browseBlock.jsp\" method=GET>");
+ out.print("<form name=\"browseblock\" action=\"/browseBlock.jsp\"
method=GET> onsubmit=\"return chunkSizeViewValidator()\">");
{code}
- In the new JavaScript code, please follow the usual coding conventions (eg
opening brace on same line as if statement, proper indentation)
- rather than complaining about whitespace, why not trim it on the server side?
- ServletUtil.htmlFooter already prints the </body> and </html> -- you're now
printing it twice
> Number format Exception is displayed in Namenode UI when the chunk size field
> is blank or string value..
> ---------------------------------------------------------------------------------------------------------
>
> Key: HDFS-1949
> URL: https://issues.apache.org/jira/browse/HDFS-1949
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20-append, 0.21.0, 0.23.0
> Reporter: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-1949.patch, hdfs-1949-1.patch, hdfs-1949.patch
>
>
> In the Namenode UI we have a text box to enter the chunk size.
> The expected value for the chunk size is a valid Integer value.
> If any invalid value, string or empty spaces are provided it throws number
> format exception.
> The existing behaviour is like we need to consider the default value if no
> value is specified.
> Soln
> ====
> We can handle numberformat exception and assign default value if invalid
> value is specified.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
