[
https://issues.apache.org/jira/browse/HDFS-13226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387305#comment-16387305
]
Yiqun Lin commented on HDFS-13226:
----------------------------------
Hi [~maobaolong],
{quote}If we change the log error to throw IOException to user, is it make
sense?
{quote}
I think we don't need to do this. It's okay to throw exception after when we
detect the invalid mount table that inputted.
Two comments for the initial patch:
1.
{code:java}
throw new IllegalArgumentException("Invalid entry. see more detail from log.");
{code}
Would you update the error message to {{Invalid entry created.}}
{{see more detail from log}} seems unnecessary.
2.Please add a simple test in {{TestRouterAdminCLI}} as [~elgoiri] also
mentioned..
I can provide the review, :).
> RBF: We should throw the failure validate and refuse this mount entry
> ---------------------------------------------------------------------
>
> Key: HDFS-13226
> URL: https://issues.apache.org/jira/browse/HDFS-13226
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Affects Versions: 3.2.0
> Reporter: maobaolong
> Assignee: maobaolong
> Priority: Major
> Labels: RBF
> Fix For: 3.2.0
>
> Attachments: HDFS-13226.001.patch
>
>
> one of the mount entry source path rule is that the source path must start
> with '\', somebody didn't follow the rule and execute the following command:
> {code:bash}
> $ hdfs dfsrouteradmin -add addnode/ ns1 /addnode/
> {code}
> But, the console show we are successful add this entry.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
