[
https://issues.apache.org/jira/browse/HDFS-13713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16625083#comment-16625083
]
Steve Loughran commented on HDFS-13713:
---------------------------------------
{checkstyle}
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractMultipartUploaderTest.java:113:
for (int i=0 ; i < size /(Integer.SIZE/Byte.SIZE); ++i) {:17: ';' is
preceded with whitespace. [NoWhitespaceBefore]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/contract/s3a/ITestS3AContractMultipartUploader.java:121:
int count =
helper.abortMultipartUploadsUnderPath(fs.pathToKey(teardown));: Line is longer
than 80 characters (found 82). [LineLength]
{code}
Also thought of something else critical to cover in spec & tests
bq. multiple parts can be uploaded from different instances of an MPU belonging
to the same user, given the same upload handle, even across machines. This also
applies to abort and complete operations.
+the contract tests should create 2 MPUs, alternating their choice of uploader
from an odd/even or purely random basis. All the tests to date use the same
instance,
Also filed HDFS-13934 on how the API for creating MPU instances should move
from service loader to FS/FC API; targeting 3.3. As that is done, the relevant
specs and javadocs will need to be updated
> Add specification of Multipart Upload API to FS specification, with contract
> tests
> ----------------------------------------------------------------------------------
>
> Key: HDFS-13713
> URL: https://issues.apache.org/jira/browse/HDFS-13713
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: fs, test
> Affects Versions: 3.2.0
> Reporter: Steve Loughran
> Assignee: Ewan Higgs
> Priority: Blocker
> Attachments: HADOOP-13713-004.patch, HADOOP-13713-004.patch,
> HADOOP-13713-005.patch, HADOOP-13713-006.patch, HDFS-13713.001.patch,
> HDFS-13713.002.patch, HDFS-13713.003.patch, multipartuploader.md
>
>
> There's nothing in the FS spec covering the new API. Add it in a new .md file
> * add FS model with the notion of a function mapping (uploadID -> Upload),
> the operations (list, commit, abort). The [TLA+
> mode|https://issues.apache.org/jira/secure/attachment/12865161/objectstore.pdf]l
> of HADOOP-13786 shows how to do this.
> * Contract tests of not just the successful path, but all the invalid ones.
> * implementations of the contract tests of all FSs which support the new API.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
