[
https://issues.apache.org/jira/browse/HDFS-14079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700795#comment-16700795
]
Íñigo Goiri commented on HDFS-14079:
------------------------------------
Thanks [^HDFS-14079-HDFS-13891.02.patch] for the patch.
* {{RouterAdminProtocal}} should be {{RouterAdminProtocol}}?
* Should we have ROUTER_ADMIN_PROTOCOL_NAME defined in HdfsConstants or leave
it as part of hadoop-hdfs-rbf?
* I would prefer to define the string as
{{RouterAdminProtocol.class.getName()}} even though the others do it
differently.
* Add a javadoc to {{RouterAdminProtocal}}.
* Instead of {{admin-address.list}}, for consistency with the NN say, we may
want to do the suffixes {{admin-address.r1}} and reuse all that logic to get
addresses.
[~virajith], you recently did the HA client for the alias map.
Can you take a pass?
> RBF: RouterAdmin should have failover concept for router
> --------------------------------------------------------
>
> Key: HDFS-14079
> URL: https://issues.apache.org/jira/browse/HDFS-14079
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 3.1.1
> Reporter: Surendra Singh Lilhore
> Assignee: Surendra Singh Lilhore
> Priority: Major
> Attachments: HDFS-14079-HDFS-13891.01.patch,
> HDFS-14079-HDFS-13891.02.patch
>
>
> Currenlty {{RouterAdmin}} connect with only one router for admin operation,
> if the configured router is down then router admin command is failing. It
> should allow to configure all the router admin address.
> {code}
> // Initialize RouterClient
> try {
> String address = getConf().getTrimmed(
> RBFConfigKeys.DFS_ROUTER_ADMIN_ADDRESS_KEY,
> RBFConfigKeys.DFS_ROUTER_ADMIN_ADDRESS_DEFAULT);
> InetSocketAddress routerSocket = NetUtils.createSocketAddr(address);
> client = new RouterClient(routerSocket, getConf());
> } catch (RPC.VersionMismatch v) {
> System.err.println(
> "Version mismatch between client and server... command aborted");
> return exitCode;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
