[
https://issues.apache.org/jira/browse/HDFS-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131464#comment-13131464
]
jirapos...@reviews.apache.org commented on HDFS-2334:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2247/
-----------------------------------------------------------
(Updated 2011-10-20 09:00:57.815922)
Review request for hadoop-hdfs.
Summary (updated)
-------
A JournalManager may take hold of resources for the duration of their lifetime.
This isn't the case at the moment for FileJournalManager, but
BookKeeperJournalManager will, and it's conceivable that FileJournalManager
could take a lock on a directory etc.
This JIRA is to add Closeable to JournalManager so that these resources can be
cleaned up when FSEditLog is closed.
This addresses bug HDFS-2334.
http://issues.apache.org/jira/browse/HDFS-2334
Diffs
-----
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupJournalManager.java
6976620
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
4a41a2c
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileJournalManager.java
8cfc975
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalManager.java
0bb7b0f
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalSet.java
0d6bc74
Diff: https://reviews.apache.org/r/2247/diff
Testing
-------
Thanks,
Ivan
> Add Closeable to JournalManager
> -------------------------------
>
> Key: HDFS-2334
> URL: https://issues.apache.org/jira/browse/HDFS-2334
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 0.23.0
>
> Attachments: HDFS-2334.diff, HDFS-2334.diff
>
>
> A JournalManager may take hold of resources for the duration of their
> lifetime. This isn't the case at the moment for FileJournalManager, but
> BookKeeperJournalManager will, and it's conceivable that FileJournalManager
> could take a lock on a directory etc.
> This JIRA is to add Closeable to JournalManager so that these resources can
> be cleaned up when FSEditLog is closed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
