[ 
https://issues.apache.org/jira/browse/HDFS-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153330#comment-13153330
 ] 

Hari Mankude commented on HDFS-2564:
------------------------------------

{quote}
       Why not just remove the catch clause entirely from refreshNamenodes? Ie 
no need to create a new exception of the same type
{quote}
done. good catch.
{quote}
    Why the new null checks for curBlock and descriptors, found a case where 
they can be null?
{quote}
compiler warning about null ptr deref.

{quote}
    The formatting of getRpcServerAddress should match the previous method (of 
the same name)
{quote}
done
                
> Cleanup unnecessary exceptions thrown and unnecessary casts
> -----------------------------------------------------------
>
>                 Key: HDFS-2564
>                 URL: https://issues.apache.org/jira/browse/HDFS-2564
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node, hdfs client, name-node
>    Affects Versions: 0.24.0
>            Reporter: Hari Mankude
>            Assignee: Hari Mankude
>            Priority: Minor
>             Fix For: 0.24.0
>
>         Attachments: HDFS-2564-1.txt, hadoop-2564.trunk.patch, 
> hadoop-2564.trunk.patch
>
>
> Cleaning up some of the java files with unnecessary exceptions and casts.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to