[
https://issues.apache.org/jira/browse/HDFS-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190171#comment-13190171
]
jirapos...@reviews.apache.org commented on HDFS-2786:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3575/
-----------------------------------------------------------
Review request for Daryn Sharp.
Summary
-------
Remove DFSUtil.getSocketAddress(), which can be misused and break tokens.
This applies to trunk now but there will be conflicts after HDFS-2784.
This addresses bug HDFS-2786.
https://issues.apache.org/jira/browse/HDFS-2786
Diffs
-----
/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
1233408
/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
1233408
/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DatanodeJspHelper.java
1233408
/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
1233408
Diff: https://reviews.apache.org/r/3575/diff
Testing
-------
Thanks,
Kihwal
> Fix host-based token incompatibilities in DFSUtil
> -------------------------------------------------
>
> Key: HDFS-2786
> URL: https://issues.apache.org/jira/browse/HDFS-2786
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node, security
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Daryn Sharp
> Assignee: Kihwal Lee
> Attachments: hdfs-2786.patch
>
>
> DFSUtil introduces new static methods that duplicate functionality in
> NetUtils. These new methods lack the logic necessary for host-based tokens
> to work. After speaking with Suresh, the approach being taken is:
> * DFSUtil.getSocketAddress will be removed. Callers will be reverted to
> using the NetUtils version.
> * DFSUtil.getDFSClient will changed to take accept a uri/host:port string
> instead of an InetSocketAddress. The method will internal call
> NetUtils.createSocketAddr. This alleviates the callers from being required to
> call NetUtils.createSocketAddr and reduce the opportunity for error that will
> break host-based tokens.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
