[ 
https://issues.apache.org/jira/browse/HDFS-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267761#comment-13267761
 ] 

Daryn Sharp commented on HDFS-3363:
-----------------------------------

This is probably just a step in the right direction, but it seems odd that 
{{BlocksMap#getINode}} isn't renamed to {{getBlockCollection}} since it now 
returns a {{BlockCollection}}.

My only concern is why pathname handling is moved into {{INode}}?  Inodes 
should be "dumb" model objects, with a controller that handles path 
manipulation -- ie. {{FSDirectory}}.
                
> blockmanagement should stop using INodeFile & INodeFileUC 
> ----------------------------------------------------------
>
>                 Key: HDFS-3363
>                 URL: https://issues.apache.org/jira/browse/HDFS-3363
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>    Affects Versions: 2.0.0, 3.0.0
>            Reporter: John George
>            Assignee: John George
>            Priority: Minor
>         Attachments: HDFS-3363.java
>
>
> Blockmanagement should stop using INodeFile and INodeFileUnderConstruction. 
> One way would be to create an interface, like BlockColletion, that is passed 
> along to the blockmanagement.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to