[ 
https://issues.apache.org/jira/browse/HDFS-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633446#comment-13633446
 ] 

Jing Zhao commented on HDFS-4700:
---------------------------------

Thanks for the comments, Nicholas! 

bq. the reference count seems not being updated in undo

This will be addressed in HDFS-4686. I'm currently working on this.

bq. Also why add verify to addSpaceConsumed? Is it for quota check?

Yes. Also we use "verify" to avoid quota check while updating quota usage in 
undo.
                
> Fix the undo section of rename with snapshots
> ---------------------------------------------
>
>                 Key: HDFS-4700
>                 URL: https://issues.apache.org/jira/browse/HDFS-4700
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-4700.000.patch, HDFS-4700.001.patch
>
>
> If a rename operation fails in the middle, the current undo section does not 
> clear the diff list. This jira aims to fix the undo logic and adds 
> corresponding unit tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to