Sorry, I was OTP when I sent that, and not fully focused. My concern is that this file must be generated via an AC_CONFIG_FILE somewhere, right? And therefore it must be included in the tarball, etc.
I guess I'm just a little surprised that it's a .in and not a .am. Just because we have a Makefile.am doesn't mean that "make dist" has to traverse down there. Is there a reason to not have it as an .am? I don't really care other than uniformity, I think -- if there's just *one* Makefile that's different, it's one more thing that has to be remembered, etc. On Sep 23, 2011, at 3:10 PM, Brice Goglin wrote: > It works fine here. > > It's basically similar to tests/embedded/ stuff (all files > in the parent EXTRA_DIST, nothing in SUBDIRS so that automake > doesn't know about it). > > Adding this Makefile.in the list of files that configure has > to manage shouldn't be a problem, we already have many .in > files that are not Makefile.am. > > Brice > > > > Le 23/09/2011 20:59, Jeff Squyres a écrit : >> Err... is this right? >> >> Does "make dist" and friends still work? >> >> >> On Sep 23, 2011, at 2:56 PM, [email protected] wrote: >> >>> Author: bgoglin >>> Date: 2011-09-23 14:56:56 EDT (Fri, 23 Sep 2011) >>> New Revision: 3845 >>> URL: https://svn.open-mpi.org/trac/hwloc/changeset/3845 >>> >>> Log: >>> Don't forget the Makefile.in in tests/rename >>> >>> It's not a .am because we don't want automake to go there >>> automatically. We just run things manually, while still >>> benefiting from configure srcdir/builddir variables >>> Added: >>> trunk/tests/rename/Makefile.in >>> >>> Added: trunk/tests/rename/Makefile.in >>> ============================================================================== >>> --- (empty file) >>> +++ trunk/tests/rename/Makefile.in 2011-09-23 14:56:56 EDT (Fri, 23 Sep >>> 2011) >>> @@ -0,0 +1,37 @@ >>> +srcdir = @srcdir@ >>> +abs_top_srcdir = @abs_top_srcdir@ >>> +abs_top_builddir = @abs_top_builddir@ >>> + >>> +all: >>> + >>> +prepare: >>> + @echo >>> + @echo "###############################" >>> + @echo Enabling renaming in headers... >>> + @echo >>> + sed -e '/^#define HWLOC_SYM_TRANSFORM 0/s/0/1/' >>> \ >>> + -e '/^#define HWLOC_SYM_PREFIX hwloc_/s/hwloc_/foobar_/1' >>> \ >>> + -e '/^#define HWLOC_SYM_PREFIX_CAPS HWLOC_/s/HWLOC_/FOOBAR_/2' >>> \ >>> + -i $(abs_top_builddir)/include/hwloc/autogen/config.h >>> $(abs_top_builddir)/include/private/autogen/config.h >>> + >>> +missing: prepare >>> + @echo >>> + @echo "###########################" >>> + @echo Finding missing renaming... >>> + @echo >>> + cpp $(srcdir)/main.c -I $(abs_top_srcdir)/include -I >>> $(abs_top_builddir)/include \ >>> + | egrep -i '(^| |\*)hwloc_' >>> + >>> +useless: prepare >>> + @echo >>> + @echo "###########################" >>> + @echo Finding useless renaming... >>> + @echo >>> + grep '^#define' $(abs_top_srcdir)/include/hwloc/rename.h \ >>> + | awk '{print $$2}' \ >>> + | egrep -v '(HWLOC_RENAME_H|HWLOC_MUNGE_NAME|HWLOC_NAME)' \ >>> + | while read name ; do \ >>> + grep $$name -rwH $(abs_top_srcdir)/include/ \ >>> + | grep -v rename.h: | grep -v .svn >/dev/null \ >>> + || echo $$name; \ >>> + done >>> _______________________________________________ >>> hwloc-svn mailing list >>> [email protected] >>> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-svn >> > > _______________________________________________ > hwloc-devel mailing list > [email protected] > http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel -- Jeff Squyres [email protected] For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/
