Hello Aleksandr, >>> You declare ice_vf_clear_all_promisc_modes() returning int, but >>> ignore the return value. >>> Looks suspicious isn't it? >> Well, it is used like that when the funciton is called locally (the >> function is not modifiedi, just made public), and really my intention >> was to clean as much as possible (so error checking is not necessary). >> In my opinion it would be enough to warn about the possible problems >> (already done in the existing function). > Can you go extra mile and add error code handling? > Or at least document it in the code why you don't do it? Ok, I can add the error handling in ice_setup_vf_trust and an extra warning to indicate that promiscuous mode clear failed when revoking trust. Just let me wait a bit longer for more possible reviews to create the next version of the series.
Thanks Best regards Jose Ignacio
