[ https://issues.apache.org/jira/browse/ARTEMIS-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730610#comment-16730610 ]
ASF GitHub Bot commented on ARTEMIS-2215: ----------------------------------------- Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2483#discussion_r244470859 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java --- @@ -193,7 +193,7 @@ public static JournalContent getType(byte type) { protected final Map<SimpleString, PersistedAddressSetting> mapPersistedAddressSettings = new ConcurrentHashMap<>(); - protected final Set<Long> largeMessagesToDelete = new HashSet<>(); + protected final Map<Long, LargeServerMessage> largeMessagesToDelete = new ConcurrentHashMap<>(); --- End diff -- It is possible to use a primitive version of the map ie using primitive longs instead of boxed types > largemessage have been consumed but not deleted from the disk during backup > and live sync > ----------------------------------------------------------------------------------------- > > Key: ARTEMIS-2215 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2215 > Project: ActiveMQ Artemis > Issue Type: Bug > Affects Versions: 2.6.3 > Reporter: yuebao > Priority: Major > > During the backup and live synchronization, the client consumes the > largemessage, then the live crash(the performCachedLargeMessageDeletes method > is not executed), after the live startup, the largemessages that have been > consumed are not deleted from the disk. -- This message was sent by Atlassian JIRA (v7.6.3#76005)