[
https://issues.apache.org/jira/browse/BEAM-11342?focusedWorklogId=516840&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-516840
]
ASF GitHub Bot logged work on BEAM-11342:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Nov/20 21:32
Start Date: 25/Nov/20 21:32
Worklog Time Spent: 10m
Work Description: ihji commented on a change in pull request #13425:
URL: https://github.com/apache/beam/pull/13425#discussion_r530652748
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1914,6 +1914,10 @@ class BeamModulePlugin implements Plugin<Project> {
// Method to create the crossLanguageValidatesRunnerTask.
// The method takes crossLanguageValidatesRunnerConfiguration as parameter.
project.ext.createCrossLanguageValidatesRunnerTask = {
+ // This task won't work if the python build file doesn't exist.
+ if (!project.project(":sdks:python").buildFile.exists()) {
+ return
Review comment:
Yeah, the complexity added to the code may not be worth it. I appended
the log message for providing some hints.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 516840)
Time Spent: 50m (was: 40m)
> fix google3 import error
> ------------------------
>
> Key: BEAM-11342
> URL: https://issues.apache.org/jira/browse/BEAM-11342
> Project: Beam
> Issue Type: Bug
> Components: cross-language, runner-dataflow
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Time Spent: 50m
> Remaining Estimate: 0h
>
> createCrossLanguageValidatesRunnerTask won't work if :sdks:python build file
> doesn't exist
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
