[ 
https://issues.apache.org/jira/browse/CALCITE-2007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201254#comment-16201254
 ] 

Gian Merlino commented on CALCITE-2007:
---------------------------------------

[~julianhyde] last time I raised a PR you asked me if I could commit it 
directly. I haven't done that before, so I'm wondering, what is the process? 
Should I click merge the PR? Or commit using the CLI git client and then close 
the PR without hitting the merge button? I can see by looking at other commits 
that it's important to include the JIRA number in the git commit message, but 
is it important to include the PR number? Or was raising a PR pointless if I 
was just going to commit it myself?

And finally is it important to get someone else to review the code first or is 
it OK to commit unilaterally?

Sorry if these questions are answered in a doc that I didn't see. Thanks!

> RexSimplify incorrectly simplifies AND bounds
> ---------------------------------------------
>
>                 Key: CALCITE-2007
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2007
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.14.0
>            Reporter: Gian Merlino
>            Assignee: Julian Hyde
>
> For example, RexSimplify incorrectly simplifies {{1 < x AND x < 3}} to {{x < 
> 3}}. Patch in linked PR.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to