[ 
https://issues.apache.org/jira/browse/CALCITE-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786068#comment-17786068
 ] 

Julian Hyde commented on CALCITE-3679:
--------------------------------------

I have reviewed [~hongyuguo]'s [PR 
3502|https://github.com/apache/calcite/pull/3502] which fixes this case and 
also CALCITE-6116. It looks good - my main requested changes are class names 
(e.g. SqlLambdaExpression to SqlLambda) and visibility (e.g. removing 
{{public}}).

The PR is in good shape. Nice work [~hongyuguo]!

My biggest concern is robustness of type-checking and validation.

Possibly the commit can be split into two - one adding lambdas, the other 
adding the EXISTS function - but let's do that right before merge.

> Allow lambda expressions in SQL queries
> ---------------------------------------
>
>                 Key: CALCITE-3679
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3679
>             Project: Calcite
>          Issue Type: New Feature
>            Reporter: Ritesh
>            Assignee: Ritesh
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: [CALCITE-3679]_Basic_implementation.patch
>
>          Time Spent: 5h 40m
>  Remaining Estimate: 0h
>
> [https://teradata.github.io/presto/docs/0.167-t/functions/lambda.html]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to