Github user chenerlu commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1192#discussion_r129598531
  
    --- Diff: 
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
    @@ -440,9 +510,16 @@ protected Expression getFilterPredicates(Configuration 
configuration) {
             for (Map.Entry<SegmentTaskIndexStore.TaskBucketHolder, 
AbstractIndex> entry :
                 segmentIndexMap.entrySet()) {
               SegmentTaskIndexStore.TaskBucketHolder taskHolder = 
entry.getKey();
    -          int taskId = 
CarbonTablePath.DataFileUtil.getTaskIdFromTaskNo(taskHolder.taskNo);
    +          int partitionId = 
CarbonTablePath.DataFileUtil.getTaskIdFromTaskNo(taskHolder.taskNo);
    +          //oldPartitionIdList is only used in alter table partition 
command because it change
    +          //partition info first and then read data.
    +          //for other normal query should use newest partitionIdList
    --- End diff --
    
    use /** */  instead


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to