[ 
https://issues.apache.org/jira/browse/OGNL-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152718#comment-13152718
 ] 

Simone Tripodi commented on OGNL-39:
------------------------------------

Thanks a lot for your contribution Adrian, more than appreciated! :)
Looks like anyway the patch solves different issues in one shot - and I now 
understand why Maurizio commits your patches step-by-step - I would like to 
kindly ask you, for future patches (the current one is fine), to split problems 
(and related patches) in different issues, to better track resolved problems. 
Not that this is an issue, but the resulting changelist would look a little too 
dense ;)
                
> Simplify OgnlRuntime
> --------------------
>
>                 Key: OGNL-39
>                 URL: https://issues.apache.org/jira/browse/OGNL-39
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Adrian Cumiskey
>            Priority: Minor
>         Attachments: patch-OGNL39.txt
>
>
> Greatly simplified OgnlRuntime, delegating away responsibilities to several 
> new classes.  Caching responsibilities are now taken by a new OgnlCache 
> class.  I also added new classes PrimitiveWrapperClasses, NumericCasts, 
> PrimitiveDefaults, NumericValues, PrimitiveTypes, NumericLiterals and 
> NumericDefaults.
> OgnlOps: Conditional simplification.
> Renamed Fie{dl,ld}CacheEntryFactory.
> TestOgnlRuntime, ClassCacheHandler: Lots of variable naming!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to