[ https://issues.apache.org/jira/browse/LANG-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15762581#comment-15762581 ]
Pascal Schumacher commented on LANG-1043: ----------------------------------------- +1 to closing this > isAllUpperCase should only check Alpha characters > ------------------------------------------------- > > Key: LANG-1043 > URL: https://issues.apache.org/jira/browse/LANG-1043 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* > Affects Versions: 3.3.2 > Reporter: Frédéric JECKER > Fix For: Discussion > > Attachments: LANG-1043.patch > > > Currently, isAllUpperCase checks character by character if the current > character is UpperCase or not using Character.isUpperCase(). > The problem is that characters like spaces aren't considered as uppercase > characters. > IMHO, isAllUpperCase should only check the state of alpha characters so that : > - StringUtils.isAllUpperCase("ABC DEF GHI") = true (false currently) > - StringUtils.isAllUpperCase("ABC / DEF") = true (false currently) -- This message was sent by Atlassian JIRA (v6.3.4#6332)