[ 
https://issues.apache.org/jira/browse/CB-9971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057380#comment-16057380
 ] 

ASF GitHub Bot commented on CB-9971:
------------------------------------

GitHub user matrosov-nikita opened a pull request:

    https://github.com/apache/cordova-android/pull/388

    Suppress line 'Picked up _JAVA_OPTIONS' from stderr

    <!--
    Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist
    is intended as a quick reference, for complete details please see our 
Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    android
    
    ### What does this PR do?
    If `_JAVA_OPTIONS` variable is defined, cordova outputs `Picked up 
_JAVA_OPTIONS: -Xmx512M` to stderr, it's interpreted to be an error, but 
actually, it's not an error. We should suppress this line for 
`runGradleWrapper` similar to 
`build`(https://issues.apache.org/jira/browse/CB-9971).
    
    ### What testing has been done on this change?
    fix auto-test for GradleBuilder logic
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matrosov-nikita/cordova-android 
suppress-java-unwanted-info

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/388.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #388
    
----
commit 0013df243e8de5aa869b433562967fa80d041092
Author: Nikita Matrosov <v-nim...@microsoft.com>
Date:   2017-06-20T07:21:39Z

    Suppress line 'Picked up _JAVA_OPTIONS' in stderr

----


> Cordova outputs "Picked up _JAVA_OPTIONS" in stderr
> ---------------------------------------------------
>
>                 Key: CB-9971
>                 URL: https://issues.apache.org/jira/browse/CB-9971
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-android
>    Affects Versions: 5.0.0
>         Environment: Windows, Tools for Apache Cordova in Visual Studio
> Cordova 5.4.0
>            Reporter: Michael Braude
>            Assignee: Vladimir Kotikov
>            Priority: Critical
>              Labels: easyfix, windows,
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Starting with version 5.4.0, Cordova now outputs "Picked up _JAVA_OPTIONS: 
> -Xmx512M" to stderr. This breaks clients such as Visual Studio because we 
> interpret messages in stderr to be errors, and this is not an error. So the 
> result is that we show deploy failures to the dev when there are no errors.
> See this for customer impact: 
> http://stackoverflow.com/questions/33603167/vs2015-build-with-cordova-cli5-4-0-shows-deployment-errors
> We can work around this in Visual Studio by using special casing, but Cordova 
> needs to output this in stdout like it did in previous versions



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to