FangYongs commented on code in PR #22289: URL: https://github.com/apache/flink/pull/22289#discussion_r1155438551
########## flink-table/flink-sql-jdbc-driver/src/main/java/org/apache/flink/table/jdbc/FlinkConnection.java: ########## @@ -18,34 +18,67 @@ package org.apache.flink.table.jdbc; +import org.apache.flink.annotation.VisibleForTesting; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.table.client.gateway.Executor; +import org.apache.flink.table.client.gateway.StatementResult; +import org.apache.flink.table.gateway.service.context.DefaultContext; +import org.apache.flink.table.jdbc.utils.DriverUtils; + import java.sql.DatabaseMetaData; import java.sql.SQLClientInfoException; import java.sql.SQLException; import java.sql.SQLFeatureNotSupportedException; import java.sql.Statement; +import java.util.Collections; import java.util.Properties; +import java.util.UUID; /** Connection to flink sql gateway for jdbc driver. */ public class FlinkConnection extends BaseConnection { - private final DriverUri driverUri; + private final Executor executor; + private volatile boolean closed = false; public FlinkConnection(DriverUri driverUri) { - this.driverUri = driverUri; + // TODO Support default context from map to get gid of flink core for jdbc driver Review Comment: Thanks @libenchao , added the jira link -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org