[
https://issues.apache.org/jira/browse/HBASE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085371#comment-13085371
]
jirapos...@reviews.apache.org commented on HBASE-4190:
------------------------------------------------------
bq. On 2011-08-13 03:33:43, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/HConstants.java, line 500
bq. > <https://reviews.apache.org/r/1461/diff/3/?file=32500#file32500line500>
bq. >
bq. > Do these constants belong here then now you've pulled up the
Interfaces? If so, thats fine... just asking.
bq.
bq. Mingjie Lai wrote:
bq. Good question. I puzzled a little bit also last time.
bq.
bq. These constants are defined as regex of HTD coprocessor related
attributes. So they're both HTD and CP related. But it's a little bit odd for
me to put some regex constants in coprocessor interface, while HConstant is
better for holding anything else. What do you think?
Your reasoning here sounds good to me Mingjie. Could go either way.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1461/#review1442
-----------------------------------------------------------
On 2011-08-13 01:08:04, Mingjie Lai wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1461/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-13 01:08:04)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Coprocessors: pull up some cp constants from cp package to
o.a.h.h.HConstants
bq.
bq.
bq. This addresses bug HBASE-4190.
bq. https://issues.apache.org/jira/browse/HBASE-4190
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/Coprocessor.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/CoprocessorEnvironment.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/HConstants.java dda254d
bq. src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java d835582
bq.
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEndpointCoprocessor.java
2fc8f39
bq.
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java
506051d
bq.
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
ec88a01
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
0290bf2
bq.
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java
54ccd6f
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
18ba6e7
bq.
src/main/java/org/apache/hadoop/hbase/coprocessor/MasterCoprocessorEnvironment.java
5d8cf4c
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/ObserverContext.java
9349d5b
bq.
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionCoprocessorEnvironment.java
da8076c
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
cfbb29d
bq.
src/main/java/org/apache/hadoop/hbase/coprocessor/WALCoprocessorEnvironment.java
6580c2c
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/WALObserver.java
b086747
bq.
src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
c44da73
bq.
src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java
03df574
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
a81ff84
bq.
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java
36816e8
bq.
src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
c85146a
bq.
src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java
0ab1339
bq.
src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java
6d31d70
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALObserver.java
d9f6e5f
bq. src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
b4c407b
bq.
bq. Diff: https://reviews.apache.org/r/1461/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestClassLoading passed locally.
bq.
bq.
bq. Thanks,
bq.
bq. Mingjie
bq.
bq.
> Coprocessors: pull up some cp constants from cp package to o.a.h.h.HConstants
> -----------------------------------------------------------------------------
>
> Key: HBASE-4190
> URL: https://issues.apache.org/jira/browse/HBASE-4190
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.90.4
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.90.5
>
>
> At HBase-3810, stack gave a comment after patch committed:
> > This is a bit odd where a class in the parent package has references to a
> > sub package.
> > Should these classes or at least their constants be pulled up to be at same
> > level as HTableD?
> Create a new jira where the constants will be pulled from
> o.a.h.h.regionserver.RegionCoprocessorHost to o.a.h.h.HConstants.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
