[
https://issues.apache.org/jira/browse/HBASE-14249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702586#comment-14702586
]
Andrew Purtell commented on HBASE-14249:
----------------------------------------
I take that back for this one. Not only are the license and meta files wrong it
doesn't make sense in the first place to have source and test jars for the
shaded artifacts. Agreed this should be a blocker.
> shaded jar modules create spurious source and test jars with incorrect
> LICENSE/NOTICE info
> ------------------------------------------------------------------------------------------
>
> Key: HBASE-14249
> URL: https://issues.apache.org/jira/browse/HBASE-14249
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.0, 1.2.0, 1.1.2
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Blocker
>
> the shaded jar modules don't need to create a source or test jar (because the
> jars contain nothing other than META-INF)
> currently we create
> * the test jars are missing LICENSE
> * source jars have LICENSE/NOTICE files that claim all the bundled works in
> the normal jar.
> {code}
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-server-1.1.2-sources.jar/
> hbase-shaded-server-1.1.2-sources.jar/
> hbase-shaded-server-1.1.2-sources.jar//META-INF
> hbase-shaded-server-1.1.2-sources.jar//META-INF/LICENSE
> hbase-shaded-server-1.1.2-sources.jar//META-INF/MANIFEST.MF
> hbase-shaded-server-1.1.2-sources.jar//META-INF/NOTICE
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-client-1.1.2-sources.jar/
> hbase-shaded-client-1.1.2-sources.jar/
> hbase-shaded-client-1.1.2-sources.jar//META-INF
> hbase-shaded-client-1.1.2-sources.jar//META-INF/LICENSE
> hbase-shaded-client-1.1.2-sources.jar//META-INF/MANIFEST.MF
> hbase-shaded-client-1.1.2-sources.jar//META-INF/NOTICE
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-client-1.1.2-tests.jar/
> hbase-shaded-client-1.1.2-tests.jar/
> hbase-shaded-client-1.1.2-tests.jar//META-INF
> hbase-shaded-client-1.1.2-tests.jar//META-INF/NOTICE
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-server-1.1.2-tests.jar/
> hbase-shaded-server-1.1.2-tests.jar/
> hbase-shaded-server-1.1.2-tests.jar//META-INF
> hbase-shaded-server-1.1.2-tests.jar//META-INF/NOTICE
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
