[
https://issues.apache.org/jira/browse/HBASE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137556#comment-13137556
]
jirapos...@reviews.apache.org commented on HBASE-4689:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2587/#review2893
-----------------------------------------------------------
there's a decent bit of refactoring here. what are the critical parts to look
at?
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java
<https://reviews.apache.org/r/2587/#comment6472>
Is printing multi-CF metrics scalable? With F families, isn't the space
complexity O(2^F)?
src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java
<https://reviews.apache.org/r/2587/#comment6471>
as an aside: have we currently started using table-level metrics in our
dashboards yet? the common abbreviation for table is "tbl" instead of "tab"
(normally, cut out the vowels). would be nice to change if we're not dependent
on this format yet.
- Nicolas
On 2011-10-27 20:23:31, Liyin Tang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2587/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-27 20:23:31)
bq.
bq.
bq. Review request for hbase, Mikhail Bautin, Pritam Damania, Prakash Khemani,
Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and
Nicolas Spiegelberg.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. In r1182034, the per table/cf for rpc* metrics has a bug. It will only
show cf level metrics even though we enabled the per table level metrics.
bq. Fix this bug here.
bq.
bq.
bq. This addresses bug HBASE-4689.
bq. https://issues.apache.org/jira/browse/HBASE-4689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6c821c0
bq.
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java
8776ffe
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java
c03532a
bq.
bq. Diff: https://reviews.apache.org/r/2587/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Passed all the unit tests and tested the rpc metrics in the dev cluster
bq.
bq.
bq. Thanks,
bq.
bq. Liyin
bq.
bq.
> [89-fb] Make the table level metrics work with rpc* metrics
> -----------------------------------------------------------
>
> Key: HBASE-4689
> URL: https://issues.apache.org/jira/browse/HBASE-4689
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.89.20100924
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: hbase-4689.patch
>
>
> In r1182034, the per table/cf for rpc* metrics has a bug. It will only show
> cf level metrics even though we enabled the per table level metrics.
> Fix this bug here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
