bbeaudreault commented on PR #4770: URL: https://github.com/apache/hbase/pull/4770#issuecomment-1315969416
May still be a bit, but I'm finally starting to look at this now. Looks like it's almost all net-new code. I checked out this branch and the following: ``` git diff --color --name-only --diff-filter=A branch-2 HBASE-27238-backport-backup-restore-to-2.x | xargs -I{} git diff master -- {} ``` Auditing the output, it shows that all of the net-new files here are relatively identical to the files from `master`. There are a few discrepancies, but all related to HBaseTestingUtility vs HBaseTestingUtil (an unfortunate difference between master/branch-2). The files with actual changes fall into four categories: 1. pom.xmls -- all seem basic boilerplate 2. hbase shell change -- just adds support for backup/restore, looks good 3. java files in test directories 4. java files in source directories There are only 3 source directory java file changes, and 2 in test. I'll be focusing my efforts on those. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org