[
https://issues.apache.org/jira/browse/HBASE-7836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620286#comment-13620286
]
Ted Yu commented on HBASE-7836:
-------------------------------
{code}
+ public MultiResponse replay(final RpcController rpcc, final MultiRequest
request)
+ throws ServiceException {
{code}
Should the method name be more informative ? How about replayHLog() or
something similar ?
{code}
* @param mutations
*/
protected void doBatchOp(final MultiResponse.Builder builder, final HRegion
region,
- final List<MutationProto> mutations, final CellScanner cells) {
+ final List<MutationProto> mutations, final CellScanner cells, boolean
inReplay) {
{code}
Add @param for inReplay.
{code}
- throw new IOException("Found invalid location string:" + loc);
+ if(tableName.isEmpty()){
+ LOG.warn("Invalid location string:" + loc + " found.");
}
- HTable table = this.tableNameToHTableMap.get(Bytes.toBytes(tableName));
-
+
+ HConnection hconn = getConnectionByTableName(Bytes.toBytes(tableName));
{code}
When tableName.isEmpty(), why would we go on fetching connection ?
{code}
- } catch (InterruptedException ix) {
- throw new InterruptedIOException("Interrupted when replaying wal
edits.");
+ } catch (RuntimeException rx) {
{code}
I think we'd better be specific about the exceptions we catch.
{code}
+ private void replayEdits(final HRegionLocation regionLoc, final HRegionInfo
regionInfo,
+ final List<Action<Row>> actions)
{code}
HRegionLocation contains HRegionInfo field. Why is regionInfo parameter needed
above ?
{code}
+ public Map<String, HRegion> getRecoveringRegions() {
+ // TODO Auto-generated method stub
{code}
You can remove the TODO above.
> Create a new "replay" command so that recovered edits won't mess up normal
> coprocessing & metrics
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-7836
> URL: https://issues.apache.org/jira/browse/HBASE-7836
> Project: HBase
> Issue Type: Sub-task
> Reporter: Jeffrey Zhong
> Assignee: Jeffrey Zhong
> Fix For: 0.95.0
>
> Attachments: hbase-7836_v1.patch, hbase-7836_v2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
