[ https://issues.apache.org/jira/browse/HIVE-12667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067343#comment-15067343 ]
Hive QA commented on HIVE-12667: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12778880/HIVE-12667.2.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 27 failed/errored test(s), 9970 tests executed *Failed tests:* {noformat} TestHWISessionManager - did not produce a TEST-*.xml file org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_join_stats2 org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver_encryption_insert_partition_dynamic org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver_vector_join_part_col_char org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_columnstats_partlvl_multiple_part_clause org.apache.hadoop.hive.ql.exec.spark.session.TestSparkSessionManagerImpl.testMultiSessionMultipleUse org.apache.hadoop.hive.ql.exec.spark.session.TestSparkSessionManagerImpl.testSingleSessionMultipleUse org.apache.hadoop.hive.ql.exec.tez.TestDynamicPartitionPruner.testExtraEvents org.apache.hadoop.hive.ql.exec.tez.TestDynamicPartitionPruner.testMissingEvent org.apache.hadoop.hive.ql.exec.tez.TestDynamicPartitionPruner.testMultipleSourcesOrdering1 org.apache.hadoop.hive.ql.exec.tez.TestDynamicPartitionPruner.testMultipleSourcesOrdering2 org.apache.hadoop.hive.ql.exec.tez.TestDynamicPartitionPruner.testMultipleSourcesOrdering3 org.apache.hadoop.hive.ql.exec.tez.TestDynamicPartitionPruner.testSingleSourceMultipleFiltersOrdering1 org.apache.hadoop.hive.ql.exec.tez.TestDynamicPartitionPruner.testSingleSourceMultipleFiltersOrdering2 org.apache.hadoop.hive.ql.exec.tez.TestDynamicPartitionPruner.testSingleSourceOrdering1 org.apache.hadoop.hive.ql.exec.tez.TestDynamicPartitionPruner.testSingleSourceOrdering2 org.apache.hadoop.hive.ql.security.authorization.plugin.TestHiveOperationType.checkHiveOperationTypeMatch org.apache.hive.jdbc.TestSSL.testSSLVersion org.apache.hive.spark.client.TestSparkClient.testAddJarsAndFiles org.apache.hive.spark.client.TestSparkClient.testCounters org.apache.hive.spark.client.TestSparkClient.testErrorJob org.apache.hive.spark.client.TestSparkClient.testJobSubmission org.apache.hive.spark.client.TestSparkClient.testMetricsCollection org.apache.hive.spark.client.TestSparkClient.testRemoteClient org.apache.hive.spark.client.TestSparkClient.testSimpleSparkJob org.apache.hive.spark.client.TestSparkClient.testSyncRpc {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6438/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6438/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6438/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 27 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12778880 - PreCommit-HIVE-TRUNK-Build > Proper fix for HIVE-12473 > ------------------------- > > Key: HIVE-12667 > URL: https://issues.apache.org/jira/browse/HIVE-12667 > Project: Hive > Issue Type: Bug > Reporter: Gunther Hagleitner > Assignee: Gunther Hagleitner > Attachments: HIVE-12667.1.patch, HIVE-12667.1.patch, > HIVE-12667.2.patch > > > HIVE-12473 has added an incorrect comment and also lacks a test case. > Benefits of this fix: > * Does not say: "Probably doesn't work" > * Does not use grammar like "subquery columns and such" > * Adds test cases, that let you verify the fix > * Doesn't rely on certain structure of key expr, just takes the type at > compile time > * Doesn't require an additional walk of each key expression > * Shows the type used in explain -- This message was sent by Atlassian JIRA (v6.3.4#6332)