panbingkun commented on code in PR #9357: URL: https://github.com/apache/iceberg/pull/9357#discussion_r1433970725
########## spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/procedures/AddFilesProcedure.java: ########## @@ -196,7 +196,7 @@ private void importFileTable( importPartitions(table, ImmutableList.of(partition), checkDuplicateFiles); } else { Preconditions.checkArgument( - !partitions.isEmpty(), "Cannot find any matching partitions in table %s", partitions); Review Comment: Obviously, `partitions` here is empty and printing is meaningless. We should print the `name of the table` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org