Fokko commented on code in PR #3011:
URL: https://github.com/apache/iceberg-python/pull/3011#discussion_r2825793016
##########
pyiceberg/table/__init__.py:
##########
@@ -396,16 +354,20 @@ def _set_ref_snapshot(
return updates, requirements
- def _build_partition_predicate(self, partition_records: set[Record]) ->
BooleanExpression:
+ def _build_partition_predicate(
Review Comment:
nit: Let's make the spec and schema non-optional, so the caller has to make
the explicit choice what to pass down the the function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
