aokolnychyi commented on a change in pull request #2276:
URL: https://github.com/apache/iceberg/pull/2276#discussion_r588797625
##########
File path:
spark3/src/main/java/org/apache/iceberg/spark/source/SparkBatchQueryScan.java
##########
@@ -106,26 +105,42 @@
}
}
- if (splitSize != null) {
- scan = scan.option(TableProperties.SPLIT_SIZE, splitSize.toString());
- }
-
- if (splitLookback != null) {
- scan = scan.option(TableProperties.SPLIT_LOOKBACK,
splitLookback.toString());
- }
-
- if (splitOpenFileCost != null) {
- scan = scan.option(TableProperties.SPLIT_OPEN_FILE_COST,
splitOpenFileCost.toString());
- }
+ scan = scan.option(TableProperties.SPLIT_SIZE,
String.valueOf(splitSize(scan)));
+ scan = scan.option(TableProperties.SPLIT_LOOKBACK,
String.valueOf(splitLookback()));
+ scan = scan.option(TableProperties.SPLIT_OPEN_FILE_COST,
String.valueOf(splitOpenFileCost()));
for (Expression filter : filterExpressions()) {
scan = scan.filter(filter);
}
- try (CloseableIterable<CombinedScanTask> tasksIterable =
scan.planTasks()) {
Review comment:
Quick question, @sunchao. If we exposed a method on `TableScan` like
`splitByPartition(boolean)` or any other name and set it from Spark, would we
be able to push down this logic into `BaseTableScan`? It seems each query
engine would need to implement it if they want to support bucketed joins.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
