kbendick commented on a change in pull request #3073:
URL: https://github.com/apache/iceberg/pull/3073#discussion_r704658095
##########
File path: core/src/main/java/org/apache/iceberg/util/BinPacking.java
##########
@@ -36,51 +36,59 @@
public static class ListPacker<T> {
private final long targetWeight;
private final int lookback;
+ private final int itemsPerBin;
private final boolean largestBinFirst;
public ListPacker(long targetWeight, int lookback, boolean
largestBinFirst) {
+ this(targetWeight, lookback, largestBinFirst, Integer.MAX_VALUE);
+ }
+
+ public ListPacker(long targetWeight, int lookback, boolean
largestBinFirst, int itemsPerBin) {
this.targetWeight = targetWeight;
this.lookback = lookback;
+ this.itemsPerBin = itemsPerBin;
Review comment:
Nit: might want to move this one below `largestBinFirst` so they're in
the same order as the parameters list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
