[ 
https://issues.apache.org/jira/browse/IGNITE-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15666808#comment-15666808
 ] 

Roman Shtykh commented on IGNITE-3066:
--------------------------------------

1) I see, you propose to call directly similarly to 
{{GridCacheCommandHandler#executeCommand}}. Is it ok to mix commands: some 
commands wrap REST and others call cache API directly?
Anyway, I won't be able to handle it in a short time, due to lack of time. The 
code is in the branch, probably someone else can do it if it has to be done 
fast.

2) I would like to keep them separate instead of having them go through 
{{switch}} etc. What is the reason to gather them in one class?

3) You are right. I'll see GET and other commands too.

4) I think it is similar, but Redis have basically two types of errors and we 
have to distinguish between them.

5) Changed to {{S.toString(GridRedisMessage.class, this)}}

6) Removed "!"

7) Added (I think it is not necessary though)

8-10) Done.


> Set of Redis commands that can be easily implemented via existing REST 
> commands
> -------------------------------------------------------------------------------
>
>                 Key: IGNITE-3066
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3066
>             Project: Ignite
>          Issue Type: Sub-task
>            Reporter: Roman Shtykh
>            Assignee: Roman Shtykh
>
> As the 1st iteration of IGNITE-2788 the following commands can be implemented 
> via existing REST commands,
> GET
> MGET
> SET
> MSET
> INCR
> DECR
> INCRBY
> DECRBY
> APPEND
> STRLEN
> GETSET
> SETRANGE
> GETRANGE
> DEL
> EXISTS
> DBSIZE
> http://redis.io/commands



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to