[
https://issues.apache.org/jira/browse/KYLIN-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259114#comment-17259114
]
ASF GitHub Bot commented on KYLIN-4859:
---------------------------------------
codecov-io commented on pull request #1537:
URL: https://github.com/apache/kylin/pull/1537#issuecomment-754814656
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1537?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base
(`kylin-on-parquet-v2@af8c8fe`). [Click here to learn what that
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1537?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## kylin-on-parquet-v2 #1537 +/- ##
======================================================
Coverage ? 24.29%
Complexity ? 4623
======================================================
Files ? 1139
Lines ? 64629
Branches ? 9545
======================================================
Hits ? 15703
Misses ? 47277
Partials ? 1649
```
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/1537?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/1537?src=pr&el=footer). Last
update
[af8c8fe...ee4a8a7](https://codecov.io/gh/apache/kylin/pull/1537?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Log4J reinitialized/reconfigured by Spark Logging
> -------------------------------------------------
>
> Key: KYLIN-4859
> URL: https://issues.apache.org/jira/browse/KYLIN-4859
> Project: Kylin
> Issue Type: Improvement
> Components: Others
> Affects Versions: v4.0.0-alpha
> Reporter: ShengJun Zheng
> Priority: Minor
>
> Spark Logging was intrucoded in kylin 4.0-alpha, it uses SL4J too, but it
> will reinitialize log4j when RootLoggers's Appender is empty.
> See:
> https://github.com/apache/spark/blob/45e19bb99acd5066723fec2bbdc0c99c696c3daf/core/src/main/scala/org/apache/spark/internal/Logging.scala#L120
> this causes some logs of a query logged in file(kylin.log), the other logged
> in stdout(kylin.out) using configuration file log4j-defaults.properties in
> spark-core_2.11-2.x.x.jar
> not firendly to read and anlyze a query performance, and may cause other
> logging confusions
> To Avoid this is, default appenders for rootLoggers should be set in
> kylin-server-log4j.properties
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
