original-brownbear commented on PR #13609: URL: https://github.com/apache/lucene/pull/13609#issuecomment-2259937170
> Presumably, this micro optimization wouldn't be visible in practice because the tasks that we run allocate even bigger objects such as IndexInput clones? I wouldn't even see this as an optimization. The point is more to avoid potential memory leaks after cancellation (I guess not quite leaks they'd resolve eventually) in case of a long queue on the executor because we'd still hold a reference to the futures list unless cancel resolves the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
