ayagmar commented on PR #15865: URL: https://github.com/apache/lucene/pull/15865#issuecomment-4128675498
> We're still dry-running though, so this would be safe to test, right? Yes. With dry-run on, this only plans and prints what it would do. It does not push a backport branch or open a backport PR. > It feels like there's quite a few changes here besides changing the action trigger That's true, and it's mainly because `push` does not have the PR context that `pull_request` had. We lose the PR number, labels, milestone, title, and merge SHA, so the workflow has to resolve pushed commits back to their merged PRs before it can decide whether to backport. We also dropped the cherry-pick action. That action is built around PR-triggered context and points forked-repo usage toward `pull_request_target`, which we don't want here! Therefore On `push`, the backport step had to become explicit. I do agree the first version was fatter than it should have been. I used LLMs while reviewing the changes, and some defensive branches slipped in that didn’t really justify themselves.. At this point, the parts I think are actually necessary are: - walk the full pushed commit range - resolve each merged PR from those commits - use that PR metadata to decide targets - perform the backport explicitly from the push context -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
